From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabian Hugelshofer Subject: Re: [PATCH 7/7] dynamic calculation of event message size for ctnetlin Date: Thu, 31 Jul 2008 17:26:41 +0100 Message-ID: <4891E7C1.2060203@gmx.ch> References: <48904B37.7090108@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Patrick McHardy , Netfilter Development Mailinglist To: Pablo Neira Ayuso Return-path: Received: from mail.gmx.net ([213.165.64.20]:58653 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751601AbYGaQ0n (ORCPT ); Thu, 31 Jul 2008 12:26:43 -0400 In-Reply-To: <48904B37.7090108@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > [PATCH] dynamic calculation of event message size for ctnetlink > > This patch adds dynamic message size calculation for ctnetlink. This > reduces CPU consumption since the overhead in the message trimming > is removed. Thanks for the patch. Just did some performance tests. On average it saves 5% CPU usage at ~1600pps (UDP packets, 1000B payload, random source ports) on my router (IXP4XX, 266Mhz). With the unclean patch the performance gain was slightly higher. I have posted it was 10%, but as far as I remember it was actually a bit less then that. The remaining difference can be explained by the length calculation overhead and measuring inaccuracy.