From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KOmTV-0003Fp-KP for mharc-grub-devel@gnu.org; Fri, 01 Aug 2008 00:42:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOmTT-0003Fh-KP for grub-devel@gnu.org; Fri, 01 Aug 2008 00:42:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOmTS-0003FV-5G for grub-devel@gnu.org; Fri, 01 Aug 2008 00:42:42 -0400 Received: from [199.232.76.173] (port=46000 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOmTR-0003FS-Vu for grub-devel@gnu.org; Fri, 01 Aug 2008 00:42:41 -0400 Received: from khepri.openbios.org ([80.190.231.112]:56351) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KOmTR-0006pk-Hr for grub-devel@gnu.org; Fri, 01 Aug 2008 00:42:41 -0400 Received: from dslb-088-066-015-201.pools.arcor-ip.net ([88.66.15.201] helo=[192.168.0.27]) by khepri.openbios.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KOmSt-0006Zl-Qr for grub-devel@gnu.org; Fri, 01 Aug 2008 06:42:07 +0200 Message-ID: <4892943F.1080000@coresystems.de> Date: Fri, 01 Aug 2008 06:42:39 +0200 From: Stefan Reinauer Organization: coresystems GmbH User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: The development of GRUB 2 References: <4892907B.8020204@coresystems.de> In-Reply-To: X-Enigmail-Version: 0.95.6 OpenPGP: id=3134D111 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: slight oddity in script parser X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2008 04:42:43 -0000 Bean wrote: > On Fri, Aug 1, 2008 at 12:26 PM, Stefan Reinauer wrote: > >> Bean wrote: >> >>> On Fri, Aug 1, 2008 at 7:48 AM, Patrick Georgi wrote: >>> >>> >>>> Hi, >>>> >>>> I forgot this, so sorry for the separate mail: >>>> Currently, the parser expects comments to start at the beginning of the >>>> line, so "ls /foo # necessary because of baz" doesn't work properly >>>> >>>> I think a good scenario would be to have comments start either on "#" at >>>> pos0, or on " #". This way, ls /foo#bar continues to work. >>>> >>>> Also, currently the following is a single comment, which is an unusual >>>> feature: >>>> # this comment starts here\ >>>> and continues on this line >>>> >>>> >>> Hi, >>> >>> Actually, # and \ is handled in the read line function, it can't >>> handle complicated situation. >>> >>> >> Are you implying it is wrong there and should be moved to the parser? >> > > Hi, > > In theory, it should be handled by the lexer. but actually, it's not > so easy. lexer already has some issue, adding new handling would not > help. > > So, what's the right way to fix it, then? -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866