All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Zhiguo <yuzg@cn.fujitsu.com>
To: Eric Paris <eparis@redhat.com>
Cc: audit-list <linux-audit@redhat.com>
Subject: Re: the format string of printf to print audit status is wrong
Date: Fri, 01 Aug 2008 17:21:35 +0800	[thread overview]
Message-ID: <4892D59F.4060304@cn.fujitsu.com> (raw)
In-Reply-To: <1217509651.2902.86.camel@localhost.localdomain>

Hello Eric,
CC Steve,

Eric Paris wrote:
> So it seems reasonable to switch backlog=%d to backlog=%u but all of the
> other values "could" be negative and should be shown as ints.
> 

 Thanks for your kindness remind.
 I also think all of the other values "could" be negative and should
be shown as ints.

 A new patch for auditctl:

---
 src/auditctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/auditctl.c b/src/auditctl.c
index d740509..44ca038 100644
--- a/src/auditctl.c
+++ b/src/auditctl.c
@@ -1350,7 +1350,7 @@ static int audit_print_reply(struct audit_reply *rep)
 			return 0;
 		case AUDIT_GET:
 			printf("AUDIT_STATUS: enabled=%d flag=%d pid=%d"
-			" rate_limit=%d backlog_limit=%d lost=%d backlog=%d\n",
+			" rate_limit=%d backlog_limit=%d lost=%d backlog=%u\n",
 			rep->status->enabled, rep->status->failure,
 			rep->status->pid, rep->status->rate_limit,
 			rep->status->backlog_limit, rep->status->lost,

  reply	other threads:[~2008-08-01  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  5:07 the format string of printf to print audit status is wrong Yu Zhiguo
2008-07-31 13:07 ` Eric Paris
2008-08-01  9:21   ` Yu Zhiguo [this message]
2008-08-04 20:11   ` Steve Grubb
2008-08-04 20:06 ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4892D59F.4060304@cn.fujitsu.com \
    --to=yuzg@cn.fujitsu.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.