All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.arm.linux.org.uk,
	Ben Dooks <ben-linux@fluff.org>,
	i2c@lm-sensors.org
Subject: Re: [PATCH] i2c-pxa: fastmode support
Date: Fri, 01 Aug 2008 10:49:24 +0100	[thread overview]
Message-ID: <4892DC24.6040204@cam.ac.uk> (raw)
In-Reply-To: <f17812d70807311829v241fce7fk23d7ff372022a342@mail.gmail.com>

Eric Miao wrote:
>> This is basically a repost of the original patch with use_pio and fast_mode converted
>> to bit fields as suggested / agreed by Eric Miao and Ben Dooks.
>>
> 
> It's generally better to use "unsigned int" for bit field please. Otherwise OK.
Good point! Concept of a 1 bit signed integer is a bit odd to say the least ;)

Patch repost with that (and Ben's point about description length) fixed shortly.

Cheers,
--
Jonathan Cameron


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

  reply	other threads:[~2008-08-01  9:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31 15:56 [PATCH] i2c-pxa: fastmode support Jonathan Cameron
     [not found] ` <4891E0C5.7020009-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-01  1:29   ` Eric Miao
2008-08-01  9:49     ` Jonathan Cameron [this message]
2008-08-01  9:42 ` Ben Dooks
     [not found]   ` <20080801094257.GK26938-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2008-08-01 10:06     ` Jonathan Cameron
2008-08-01 10:09       ` Russell King - ARM Linux
2008-08-01 10:12         ` Jonathan Cameron
     [not found]           ` <4892E183.7090601-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-01 10:16             ` [PATCH] i2c-pxa: fastmode support (format cleanups) Jonathan Cameron
     [not found]               ` <4892E28E.40202-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-01 10:37                 ` Eric Miao
2008-08-01 10:08     ` [PATCH] i2c-pxa: fastmode support (with suggested fixes) Jonathan Cameron
     [not found]       ` <4892E08F.4000907-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-06 22:40         ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4892DC24.6040204@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=ben-linux@fluff.org \
    --cc=eric.y.miao@gmail.com \
    --cc=i2c@lm-sensors.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.