From: "David Müller" <dave.mueller@gmx.ch>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Fix a large collection of DMA mode mismatches
Date: Fri, 01 Aug 2008 13:56:56 +0200 [thread overview]
Message-ID: <4892FA08.7070403@gmx.ch> (raw)
In-Reply-To: <20080801091834.5ca39334@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> drivers/ata/libata-core.c | 4 ++--
> drivers/ata/pata_acpi.c | 2 +-
> drivers/ata/pata_atiixp.c | 2 +-
> drivers/ata/pata_cs5530.c | 6 +++---
> drivers/ata/pata_sc1200.c | 6 +++---
> include/linux/libata.h | 22 ++++++++++++++++++++++
> 6 files changed, 32 insertions(+), 10 deletions(-)
A patch for the "pata_oldpiix" driver seems to be missing.
Signed-off-by: Dave Mueller <dave.mueller@gmx.ch>
diff -dpurN a/drivers/ata/pata_oldpiix.c b/drivers/ata/pata_oldpiix.c
--- a/drivers/ata/pata_oldpiix.c 2008-07-14 18:19:53.000000000 +0200
+++ b/drivers/ata/pata_oldpiix.c 2008-08-01 13:17:34.000000000 +0200
@@ -198,7 +198,7 @@ static unsigned int oldpiix_qc_issue(str
if (adev != ap->private_data) {
oldpiix_set_piomode(ap, adev);
- if (adev->dma_mode)
+ if (ata_dma_enabled(adev))
oldpiix_set_dmamode(ap, adev);
}
return ata_sff_qc_issue(qc);
next prev parent reply other threads:[~2008-08-01 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 8:18 [PATCH] libata: Fix a large collection of DMA mode mismatches Alan Cox
2008-08-01 11:56 ` David Müller [this message]
2008-08-01 22:42 ` Alan Cox
2008-08-03 4:45 ` Tejun Heo
2008-08-03 13:08 ` Alan Cox
2008-08-03 14:02 ` Tejun Heo
2008-08-22 6:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4892FA08.7070403@gmx.ch \
--to=dave.mueller@gmx.ch \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.