From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] Re: distclean failure
Date: Fri, 01 Aug 2008 13:55:32 -0700
Message-ID: <48937844.4060504@goop.org>
References: <200808011614.56245.Christoph.Egger@amd.com>
	<20080801141820.GU4553@implementation.uk.xensource.com>
	<489371B1.1030600@goop.org> <20080801203642.GB4526@implementation>
	<489374BF.4010802@goop.org> <20080801204245.GC4526@implementation>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080801204245.GC4526@implementation>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Samuel Thibault <samuel.thibault@eu.citrix.com>, Jeremy Fitzhardinge <jeremy@goop.org>, Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Samuel Thibault wrote:
> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a =E9crit :
>  =20
>> Samuel Thibault wrote:
>>    =20
>>> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a =E9crit :
>>> =20
>>>      =20
>>>>> +	[ ! -d libxc ] || $(MAKE) -C libxc clean
>>>>> +	[ ! -d ioemu ] || $(MAKE) -C ioemu clean
>>>>>     =20
>>>>>          =20
>>>> Are you sure you don't not need a double negative there?
>>>>   =20
>>>>        =20
>>> Mmm, why?  The clean target succeeds if either there is not even
>>> libxc/ioemu directories, or the make clean there works.
>>> =20
>>>      =20
>> I'm just pointing out that
>>
>> 	[ -d libxc ] && $(MAKE) -C libxc clean
>>
>> is more straightforward.
>>    =20
>
> But it makes the rule fail if the directory doesn't exist.
>  =20

Blerk.  OK.

    J