All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, dev <dev@dpdk.org>,
	Honnappa.Nagarahalli@arm.com, Andrew Boyer <aboyer@pensando.io>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: provide suitable error for "both" libraries option
Date: Wed, 20 Jan 2021 01:49:49 +0100	[thread overview]
Message-ID: <4894559.8TOBBnaypU@thomas> (raw)
In-Reply-To: <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io>

11/01/2021 17:19, Andrew Boyer:
> > On Jan 11, 2021, at 8:55 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> > 
> > Rather than having the DPDK configuration error out when linking apps
> > and examples when "both" is select for "default_library" option, we can
> > detect that setting earlier in the build config and provide a suitable
> > error message to the user.
> > 
> > CC: stable@dpdk.org
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > +if get_option('default_library') == 'both'
> > +	error( '''
> > +    Unsupported value "both" for "default_library" option.
> > +
> > +    NOTE: DPDK always builds both shared and static libraries.  Please set
> > +    "default_library" to either "static" or "shared" to select default linkage
> > +    for apps and any examples''')
> 
> Should there be a period after ‘examples’?
> 
> Reviewed-by: Andrew Boyer <aboyer@pensando.io>

Applied with above fixup, thanks




  parent reply	other threads:[~2021-01-20  0:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 13:55 [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option Bruce Richardson
2021-01-11 16:19 ` Andrew Boyer
2021-01-11 16:57   ` Bruce Richardson
2021-01-20  0:49   ` Thomas Monjalon [this message]
2021-01-11 17:40 ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4894559.8TOBBnaypU@thomas \
    --to=thomas@monjalon.net \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=aboyer@pensando.io \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.