Re: [PATCH] Support for new rtl810x hardware

[Ivan Vecera <ivecera@redhat.com>]

> Francois Romieu <romieu@fr.zoreil.com> :
> [...]
> 
> I have published a new serie at:
> 
> http://userweb.kernel.org/~romieu/r8169/2.6.27-rc1
> 
> It does not include the 8168 chipsets specific bits which are currently
> in the r8169 branch at git.kernel.org.
> 
> I'd appreciate if you could give the serie a try and tell me if it is
> ok to add your s-o-b to the patch below. It is synched with version
> 1.008.00 of Realtek 8101 driver (which exhibits some phy_config
> changes).
Yes, from my point of view it's OK.

> ...
> The 0x7c800000 mask is more or less reserved for the fallback,
> whence the introduction of the 0x34a00000 identifier.
Yes this is

> I have not understood under which basis you made a difference
> between 8102e and 8102el. As far as I can tell Realtek's driver
> does not disambiguate either: 0x34a00000 (resp. 0x34800000) and
> 0x24a00000 (resp. 0x24800000) both fall under CFG_METHOD_5
> (resp. CFG_METHOD_3). Did I miss something or was is more or
> less arbitrary ?
There was my mistake to use rtl8102e_hw_phy_config and
rtl8102el_hw_phy_config identifiers. But Realtek's driver v1.007.00
used different PHY configuration for CFG_METHOD_3 and for
CFG_METHOD_4/5. The current (v1.009.00) uses the common one for all
of them.

Regards,
Ivan