Re: [Qemu-devel] [PATCH v2] Fix compilation of nbd on Windows

[Anthony Liguori <anthony@codemonkey.ws>]

Johannes Schindelin wrote:
> Hi,
>
> On Sun, 3 Aug 2008, Anthony Liguori wrote:
>
>   
>> Johannes Schindelin wrote:
>>
>>     
>>> Indeed, it seems that inet_aton() is defined in slirp/misc.c.  So 
>>> qemu_socket.h is not even the right place for the definition, but 
>>> better than nothing.
>>>       
>> Ugh, I wonder what happens when you do --disable-slirp :-( Do you want 
>> to work up a patch to sanitize all of this or should I?
>>     
>
> You mean to keep my static implementation, but put it in an #ifndef 
> CONFIG_SLIRP, with the #else branch declaring the function?
>
> Sure, I can do it, just tell me if that is what you meant.
>   

It's all pretty messy right now.  I tried to wrap your static 
implementation in a #ifdef QEMU_IMG but then nbd.o gets linked into both 
qemu and qemu-nbd which makes things a pain.  I actually ended up just 
removing the declaration in vl.c and that seemed to work.

Whatever you can do that will make it so we're only using a single 
implementation of inet_aton() will make me happy.

Regards,

Anthony Liguori

> Ciao,
> Dscho
>
>