All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: iptables-restore: fix segmentation fault with -tanything
Date: Mon, 04 Aug 2008 12:51:50 +0200	[thread overview]
Message-ID: <4896DF46.9070605@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0808031501080.27230@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> commit e075edd231346496d9e93477704a74c9c664bfc7
> Author: Michael Spang <mspang@uwaterloo.ca>
> Date:   Sun Aug 3 15:00:26 2008 -0400
> 
> iptables-restore: fix segmentation fault with -tanything
> 
> Reference: Debian bug #458042
> 
> iptables-restore must not pass a table into do_command. It checks for
> "-t arg" and "--table arg", but not "-targ". (On a related note,
> using -targ does not work as expected).
> 
> This should fail gracefully, but crashes:
> 
> 	iptables-restore <(echo -e '*filter\n-A INPUT -tx\nCOMMIT')
> 
> And this should use table "filter", or perhaps raise an error, but
> instead sets the table to (literally) "-tfilter":
> 
> 	iptables -tfilter -A INPUT


Applied, thanks.

      reply	other threads:[~2008-08-04 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-03 19:02 iptables-restore: fix segmentation fault with -tanything Jan Engelhardt
2008-08-04 10:51 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4896DF46.9070605@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.