From: Brad King <brad.king@kitware.com>
To: Dmitry Potapov <dpotapov@gmail.com>
Cc: Eric Wong <normalperson@yhbt.net>, git@vger.kernel.org
Subject: Re: [PATCH] correct access right for git-svn-dcommit test
Date: Mon, 04 Aug 2008 11:44:06 -0400 [thread overview]
Message-ID: <489723C6.7060806@kitware.com> (raw)
In-Reply-To: <20080804153024.GV7008@dpotapov.dyndns.org>
Dmitry Potapov wrote:
> The tests requires anonymous write access. Therefore, "anon-access =
> write" is added to conf/svnserve.conf. But because it was added to
> the end of the file, it is impossible to guarantee in what section
> it will be located. It turned out that on SVN 1.5, it was placed in
> the wrong section and as result the test failed.
>
> Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
> ---
> t/t9113-git-svn-dcommit-new-file.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/t/t9113-git-svn-dcommit-new-file.sh b/t/t9113-git-svn-dcommit-new-file.sh
> index 8da8ce5..ae78e33 100755
> --- a/t/t9113-git-svn-dcommit-new-file.sh
> +++ b/t/t9113-git-svn-dcommit-new-file.sh
> @@ -28,6 +28,7 @@ start_svnserve () {
>
> test_expect_success 'start tracking an empty repo' '
> svn mkdir -m "empty dir" "$svnrepo"/empty-dir &&
> + echo "[general]" > "$rawsvnrepo"/conf/svnserve.conf &&
> echo anon-access = write >> "$rawsvnrepo"/conf/svnserve.conf &&
> start_svnserve &&
> git svn init svn://127.0.0.1:$SVNSERVE_PORT &&
I just tried this patch and it does fix the test on my system.
Thanks,
-Brad
next prev parent reply other threads:[~2008-08-04 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 21:40 [PATCH 1/2] git-svn: teach dcommit about svn auto-props Brad King
2008-07-25 6:00 ` Eric Wong
2008-07-25 15:32 ` [PATCH] " Brad King
2008-07-26 5:45 ` Eric Wong
2008-07-26 14:08 ` Brad King
2008-08-03 22:02 ` [RFH] - git-svn auth bug (possibly SVN 1.5.0-related) Eric Wong
2008-08-04 14:18 ` Dmitry Potapov
2008-08-04 15:14 ` Dmitry Potapov
2008-08-04 15:30 ` [PATCH] correct access right for git-svn-dcommit test Dmitry Potapov
2008-08-04 15:44 ` Brad King [this message]
2008-08-05 3:18 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489723C6.7060806@kitware.com \
--to=brad.king@kitware.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.