All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Jan Engelhardt <jengelh@medozas.de>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: rfc: reject use of drop in nat table
Date: Mon, 04 Aug 2008 21:08:12 +0200	[thread overview]
Message-ID: <4897539C.1080102@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0808042050300.7375@blackhole.kfki.hu>

Jozsef Kadlecsik wrote:
> On Mon, 4 Aug 2008, Patrick McHardy wrote:
> 
>> Jan Engelhardt wrote:
>>> This just happened to be within my thoughts. Comments, declinations?
>> Well, first thought is the usual fear of breaking setups.
>>
>> But I do agree that this makes sense, we've had a number
>> of "bugreports" over the years from people how tried to
>> do filtering in the nat table and didn't realize it only
>> sees the first packet of a connection.
>>
>> Not sure - anyone else with an opinion? :)
> 
> Instead of the line
> 
> +                       exit_error(OTHER_PROBLEM, "The nat table is not for filtering");
> 
> the next one would probably be little bit more user friendly:
> 
> +                       fprintf(stderr, "The nat table is not for filtering, next iptables release won't support it at all. Fix your setup.\n");
> 
> And in the next release it could be changed to 'exit_error'.

That sounds good, lets do that.

  reply	other threads:[~2008-08-04 19:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04 16:54 rfc: reject use of drop in nat table Jan Engelhardt
2008-08-04 16:57 ` Patrick McHardy
2008-08-04 18:05   ` Phil Oester
2008-08-04 18:55   ` Jozsef Kadlecsik
2008-08-04 19:08     ` Patrick McHardy [this message]
2008-08-10 14:44       ` Jan Engelhardt
2008-08-13 12:42         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4897539C.1080102@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.