All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Charles Duffy <Charles_Duffy@messageone.com>
Cc: kvm@vger.kernel.org
Subject: Re: e1000 PXE breakage bisected down in kvm-userspace
Date: Mon, 04 Aug 2008 16:43:21 -0500	[thread overview]
Message-ID: <489777F9.1080404@codemonkey.ws> (raw)
In-Reply-To: <g77rm6$ils$1@ger.gmane.org>

Charles Duffy wrote:
> Anthony Liguori wrote:
>> Charles Duffy wrote:
>>> Per subject. "git bisect run" script (and libvirt xml helper) attached.
>>
>> Does the problem go away if you make the e1000_can_receive() function 
>> always return 1?
>
> Yes.

Presumably, this is the proper fix.  Can you verify?

diff --git a/qemu/hw/e1000.c b/qemu/hw/e1000.c
index 1be69ec..6a07b0c 100644
--- a/qemu/hw/e1000.c
+++ b/qemu/hw/e1000.c
@@ -521,8 +521,8 @@ e1000_can_receive(void *opaque)
 {
     E1000State *s = opaque;
 
-    return ((s->mac_reg[RCTL] & E1000_RCTL_EN) &&
-           s->mac_reg[RDH] != s->mac_reg[RDT]);
+    return (!(s->mac_reg[RCTL] & E1000_RCTL_EN) ||
+            s->mac_reg[RDH] != s->mac_reg[RDT]);
 }
 
 static void

Regards,

Anthony Liguori

> -- 
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2008-08-04 21:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04 21:02 e1000 PXE breakage bisected down in kvm-userspace Charles Duffy
2008-08-04 21:11 ` Anthony Liguori
2008-08-04 21:17   ` Charles Duffy
2008-08-04 21:43     ` Anthony Liguori [this message]
2008-08-04 22:00       ` Charles Duffy
2008-08-05  1:07       ` Charles Duffy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489777F9.1080404@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Charles_Duffy@messageone.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.