From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [RFC][PATCH 0/6] Enable multiple mounts of devpts Date: Mon, 04 Aug 2008 18:37:18 -0700 Message-ID: <4897AECE.9060307@zytor.com> References: <20080805011844.GA14940@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080805011844.GA14940-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Cc: kyle-hoO6YkzgTuCM0SS3m2neIg@public.gmane.org, "David C. Hansen" , bastian-yyjItF7Rl6lg9hUCZPvPmw@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org wrote: > > If devpts is mounted more than once, then '/dev/ptmx' must be a symlink > to '/dev/pts/ptmx' and in each new devpts mount we must create the > device node '/dev/pts/ptmx' [c, 5;2] by hand. > This should be auto-created. That also eliminates any need to support the mknod system call. > Appreciate comments on overall approach of my mapping from the inode > to sb->s_fs_info to allocated_ptys and the hacky use of get_sb_nodev(), > and also on the tweak to init_dev() (patch 6). > > Todo: > User-space impact of /dev/ptmx symlink - Options are being > discussed on mailing list (new mount option and config token, > new fs name, etc) > > Remove even initial kernel mount of devpts ? The initial kernel mount of devpts should be removed, since that instance will never be accessible. -hpa