From: John Rigby <jrigby@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.
Date: Tue, 05 Aug 2008 15:38:13 -0600 [thread overview]
Message-ID: <4898C845.3080606@freescale.com> (raw)
In-Reply-To: <4898C434.4040408@freescale.com>
Scott Wood wrote:
> John Rigby wrote:
>> I would like to use mpc83xx_add_bridge for 5121. This is why I
>> moved it to fsl_pci.c. It currently uses get_immrbase and adds
>> 0x8300 and 0x8304 to it to pass to setup_indirect_pci as the
>> cfg_addr, and cfg_data addresses.
>>
>> I'm more than willing to change mpc83xx_add_bridge to not use
>> get_immrbase. One simple solution is to pass the cfg_addr and
>> cfg_data addresses in. If that seems ok then thats what I will do.
>
> We should really be putting those addresses in the "reg" property of
> the PCI node.
>
> -Scott
>
Yes, which is what fsl_add_bridge does it.
next prev parent reply other threads:[~2008-08-05 21:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:13 [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 3/4] powerpc: 83xx: Add immr aliases to 83xx device trees John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 4/4] powerpc: 8[56]xx: Add immr aliases to 8[56]xx " John Rigby
2008-08-05 21:05 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree Grant Likely
2008-08-05 21:05 ` Grant Likely
2008-08-05 21:17 ` John Rigby
2008-08-05 21:20 ` Scott Wood
2008-08-05 21:20 ` Scott Wood
2008-08-05 21:38 ` John Rigby [this message]
2008-08-05 21:08 ` Scott Wood
2008-08-05 21:12 ` Grant Likely
2008-08-05 21:19 ` Scott Wood
2008-08-05 23:46 ` Anton Vorontsov
2008-08-05 20:43 ` [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists Arnd Bergmann
2008-08-05 20:49 ` Scott Wood
2008-08-05 20:50 ` Kumar Gala
2008-08-05 21:08 ` Grant Likely
2008-08-05 21:08 ` Grant Likely
2008-08-06 3:41 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4898C845.3080606@freescale.com \
--to=jrigby@freescale.com \
--cc=devicetree-discuss@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.