From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/4] hwmon: (w83791d) add pwm_enable support
Date: Wed, 06 Aug 2008 08:30:52 +0000 [thread overview]
Message-ID: <4899613C.70405@hhs.nl> (raw)
In-Reply-To: <200808060029.41402.m.hulsman@tudelft.nl>
Marc Hulsman wrote:
>> And here you store the register val + 1 again, making show_pwmenable
>> actually show the less value, unless pwm#_enable is read very quickly after
>> a write, in which case w83791d_update won't do anything and the shown
>> pwm_enable value will be one to small.
>>
>> I think it would be best to consistently store the val as seen by userspace
>> - 1 (iow the actual reg val) in pwm_enable (as you do in store_pwmenable)
>> and then add the + 1 when showing it.
>
> Thanks for spotting that one, I should have seen it. Hereby a new version of
> the patch:
>
> ---
> Add support for pwm_enable.
>
> Signed-off-by: Marc Hulsman <m.hulsman@tudelft.nl>
>
Looks good now:
Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-08-06 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 22:29 [lm-sensors] [PATCH 3/4] hwmon: (w83791d) add pwm_enable support Marc Hulsman
2008-08-06 7:59 ` Hans de Goede
2008-08-06 8:17 ` Marc Hulsman
2008-08-06 8:30 ` Hans de Goede [this message]
2008-09-30 14:54 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4899613C.70405@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.