From: Zhang Xiliang <zhangxiliang@cn.fujitsu.com>
To: Steve Grubb <sgrubb@redhat.com>, Linux Audit <linux-audit@redhat.com>
Subject: Re: [PATCH 1/5] Add the field checking for missing value after opration
Date: Wed, 06 Aug 2008 16:46:27 +0800 [thread overview]
Message-ID: <489964E3.40702@cn.fujitsu.com> (raw)
In-Reply-To: <48995CFA.5020302@cn.fujitsu.com>
Hello Steve,
> if (v == NULL || f == v)
> return -1;
I have some questions for "f == v".
I think it only checks the address of "f" and "v". It seems unuseful.
If we need to check whether the value is equal to the field, I think we should use strcmp().
What your opinion about it?
If you agree with me, I will make another patch for it.
next prev parent reply other threads:[~2008-08-06 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 8:12 [PATCH 1/5] Add the field checking for missing value after opration Zhang Xiliang
2008-08-06 8:46 ` Zhang Xiliang [this message]
2008-08-06 19:19 ` Steve Grubb
2008-08-06 18:59 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489964E3.40702@cn.fujitsu.com \
--to=zhangxiliang@cn.fujitsu.com \
--cc=linux-audit@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.