From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: Kernel Summit request for Discussion of future of ATA (libata) and IDE Date: Wed, 06 Aug 2008 15:27:07 +0400 Message-ID: <48998A8B.9040109@ru.mvista.com> References: <48976168.3020804@shaw.ca> <20080804205508.20a3f917@lxorguk.ukuu.org.uk> <48977200.3050307@shaw.ca> <20080804220619.76b94ceb@lxorguk.ukuu.org.uk> <4898EE70.1030604@shaw.ca> <4898F3EA.7000507@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:40034 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758440AbYHFL1Q (ORCPT ); Wed, 6 Aug 2008 07:27:16 -0400 In-Reply-To: <4898F3EA.7000507@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Robert Hancock , Alan Cox , Bartlomiej Zolnierkiewicz , James Bottomley , ksummit-2008-discuss@lists.linux-foundation.org, linux-kernel , linux-ide , Jeff Garzik Hello. Tejun Heo wrote: >> +unsigned int ata_sff_data_xfer(struct ata_device *dev, unsigned char *buf, >> + unsigned int buflen, int rw) >> +{ >> + struct ata_port *ap = dev->link->ap; >> + void __iomem *data_addr = ap->ioaddr.data_addr; >> + unsigned int words = buflen >> 2; >> > > dwords maybe? > Isn't word 32-bit in the 32-bit systems? We're not on 80[12]86 (despite Intel/MS preference of calling 32-bit memory cells DWORDS)... MBR, Sergei