From: Max Krasnyansky <maxk@qualcomm.com>
To: unlisted-recipients:; (no To-header on input)
Cc: mingo@elte.hu, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, lizf@cn.fujitsu.com,
jeff.chua.linux@gmail.com
Subject: Re: [PATCH] Resurect proper handling of maxcpus= kernel option
Date: Wed, 06 Aug 2008 13:23:31 -0700 [thread overview]
Message-ID: <489A0843.6050205@qualcomm.com> (raw)
In-Reply-To: <1218052854-5020-1-git-send-email-Krasnyansky@qualcomm.com>
> From: Max Krasnyansky <maxk@qualcomm.com>
>
> For some reason we had redundant parsers registered for maxcpus=.
> One in init/main.c and another in arch/x86/smpboot.c
> So I nuked the one in arch/x86.
>
> Also 64-bit kernels used to handle maxcpus= as documented in
> Documentation/cpu-hotplug.txt. CPUs with 'id > maxcpus' are initialized
> but not booted. 32-bit version for some reason ignored them even though
> all the infrastructure for booting them later is there.
>
> In the current mainline both 64 and 32 bit versions are broken. I'm
> too lazy to look through git history but I'm guessing it happened as
> part of the i386 and x86_64 unification.
>
> This patch restores the correct behaviour. I've tested x86_64 version on
> 4- and 8- way Core2 and 2-way Opteron based machines. Various config
> combinations SMP, !SMP, CPU_HOTPLUG, !CPU_HOTPLUG.
> Booted with maxcpus=1 and maxcpus=4, etc. Everything is working as expected.
>
> I cannot test 32-bit version (no 32-bit machines here).
>
> Signed-off-by: Max Krasnyansky <maxk@qualcomm.com>
> Cc: lizf@cn.fujitsu.com
> Cc: jeff.chua.linux@gmail.com
I just realized that I managed to screw up my From: email address in
git-send-email command line. Please reply to maxk@qualcomm.com.
Max
next prev parent reply other threads:[~2008-08-06 20:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 20:00 [PATCH] Resurect proper handling of maxcpus= kernel option Max.Krasnyansky
2008-08-06 20:23 ` Max Krasnyansky [this message]
2008-08-07 4:00 ` Li Zefan
2008-08-07 5:48 ` Jeff Chua
2008-08-07 17:22 ` Max Krasnyansky
2008-08-07 17:21 ` Max Krasnyansky
2008-08-08 2:13 ` Li Zefan
2008-08-11 18:16 ` Ingo Molnar
2008-08-11 18:28 ` Max Krasnyansky
2008-08-11 18:38 ` Ingo Molnar
2008-08-11 18:46 ` Max Krasnyansky
2008-08-11 18:40 ` Max Krasnyansky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A0843.6050205@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=akpm@linux-foundation.org \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.