All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@seznam.cz>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] FIT: Fix handling of images without ramdisks
Date: Wed, 06 Aug 2008 22:26:58 +0200	[thread overview]
Message-ID: <489A0912.1060304@seznam.cz> (raw)
In-Reply-To: <1217951517-823-1-git-send-email-ptyser@xes-inc.com>

Hi Peter,

I tested current head on my boards and I have no problem with it.
Can you post your config part where you have problem?
And I look at 85xx repo and I haven't found this fix there. The last patch on
master branch in mine.

Regards,
Michal Simek



> boot_get_ramdisk() should not treat the case when a FIT image does not contain a ramdisk as an error.
> 
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---
> The original code would not allow booting of a FIT image which didn't contain a ramdisk.  The bug was observed and fixed on a powerpc 85xx system.
> 
>  common/image.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/image.c b/common/image.c
> index 535c302..c3545a7 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -833,7 +833,7 @@ int boot_get_ramdisk (int argc, char *argv[], bootm_headers_t *images,
>  			rd_noffset = fit_conf_get_ramdisk_node (fit_hdr, cfg_noffset);
>  			if (rd_noffset < 0) {
>  				debug ("*  ramdisk: no ramdisk in config\n");
> -				return 1;
> +				return 0;
>  			}
>  		}
>  #endif

  reply	other threads:[~2008-08-06 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-05 15:51 [U-Boot-Users] [PATCH] FIT: Fix handling of images without ramdisks Peter Tyser
2008-08-06 20:26 ` Michal Simek [this message]
2008-08-06 21:11   ` Peter Tyser
2008-08-07  6:48     ` Michal Simek
2008-08-07  7:37 ` Michal Simek
2008-08-09 17:43 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489A0912.1060304@seznam.cz \
    --to=monstr@seznam.cz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.