From: Tejun Heo <tj@kernel.org>
To: Alexander Inyukhin <shurick@sectorb.msk.ru>
Cc: linux-ide@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
Borislav Petkov <petkovbb@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [patch] cdrom: Handle TOC
Date: Thu, 07 Aug 2008 08:11:45 +0900 [thread overview]
Message-ID: <489A2FB1.1060603@kernel.org> (raw)
In-Reply-To: <20080806210358.GA7386@shurick.s2s.msu.ru>
Alexander Inyukhin wrote:
> index d9d1b65..efc3aa0 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -394,6 +394,8 @@ int register_cdrom(struct cdrom_device_info *cdi)
>
> if (cdo->open == NULL || cdo->release == NULL)
> return -EINVAL;
> + if (cdo->audio_ioctl == NULL)
> + return -EINVAL;
Maybe sticking a BUG_ON() is a good idea just in case?
--
tejun
next prev parent reply other threads:[~2008-08-06 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 21:03 [patch] cdrom: Handle TOC Alexander Inyukhin
2008-08-06 23:11 ` Tejun Heo [this message]
2008-08-07 4:23 ` Borislav Petkov
2008-08-07 4:18 ` Borislav Petkov
2008-08-07 17:11 ` Alexander Inyukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A2FB1.1060603@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=petkovbb@googlemail.com \
--cc=shurick@sectorb.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.