All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John W Linville <linville@tuxdriver.com>,
	chunkeey@web.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] p54: Fix regression due to commit b19fa1f
Date: Thu, 07 Aug 2008 10:20:39 -0500	[thread overview]
Message-ID: <489B12C7.80901@lwfinger.net> (raw)
In-Reply-To: <1218115671.23048.174.camel@johannes.berg>

Johannes Berg wrote:
>> +			priv->tx_stats[le32_to_cpu(entry_data->frame_type - 4)].len--;
> 
> Sorry for not catching this earlier, but this looks wrong, the -4 surely
> should be outside the endian conversion?

I thought mixed-endian arithmetic was the latest rage ;). I'll sent V2 right away.

Have a good vacation.

Larry

  reply	other threads:[~2008-08-07 15:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 13:21 [PATCH] p54: Fix regression due to commit b19fa1f Larry Finger
2008-08-07 13:27 ` Johannes Berg
2008-08-07 15:20   ` Larry Finger [this message]
2008-08-07 15:27   ` Chr
2008-08-07 15:26     ` Johannes Berg
2008-08-07 15:27     ` Johannes Berg
2008-08-07 16:00       ` Chr
2008-08-07 16:34         ` Michael Buesch
2008-08-07 15:59     ` Larry Finger
2008-08-07 23:18       ` Chr
  -- strict thread matches above, loose matches on Subject: below --
2008-08-04 21:14 Larry Finger
2008-08-06 22:57 ` Chr
2008-08-07  3:33   ` Larry Finger
2008-08-07  7:33     ` Chr
2008-08-07  6:35   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489B12C7.80901@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chunkeey@web.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.