From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: [PATCH] fix serial emulation Date: Thu, 07 Aug 2008 18:44:52 +0100 Message-ID: <489B3494.6020008@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org There is a small bug on the serial emulation code that prevents kgdb from working correctly over the serial. This patch fixes it. Signed-off-by: Stefano Stabellini --- diff --git a/hw/serial.c b/hw/serial.c index d090a2b..8e161dd 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -219,7 +219,7 @@ static void serial_update_irq(SerialState *s) } else if ( s->timeout_ipending ) { tmp_iir = UART_IIR_CTI; } else if ( ( s->ier & UART_IER_RDI ) && (s->lsr & UART_LSR_DR ) ) { - if ( !(s->iir & UART_FCR_FE) ) { + if ( !(s->fcr & UART_FCR_FE) ) { tmp_iir = UART_IIR_RDI; } else if ( s->recv_fifo.count >= s->recv_fifo.itl ) { tmp_iir = UART_IIR_RDI;