From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Hope Subject: [reiser4] Point Date: Thu, 07 Aug 2008 14:54:53 -0400 Message-ID: <489B44FD.5000108@gmail.com> References: <558.1643-13003-1386678025-1217242012@post.cz> <488DD846.70002@gmail.com> <48971680.2010906@gmail.com> <4897333E.3030600@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=5KDOGoY0m/AmsuRmoKPlDC1ejQxkSc6wludclj46QbU=; b=jE0gMIueT8ORxoqG7Y4j8qtgoX1mfKywh84X/UxcZac+3yEXbZSfEWBNpqlt8334+p FrHsW6dUfvOGWRfyotvZ2YlfOVRTI3IKvshp63a9tLreWJn8b2lV4qzPSoiG2oeXunr8 Ny/dr3/ky6a0pLD4qATPbREJIYnouONaYG3Dw= In-Reply-To: Sender: reiserfs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: edward.shishkin@gmail.com, reiserfs-devel@vger.kernel.org Is this todo really done? >> As in point 6. in todo list (pub.namesys.com/Reiser4/ToDo ) try to >> replace wake_up() with wake_up_process() There are still a few more wake_up()'s in the code, the following patch takes care of 2 of them. diff --git a/fs/reiser4/entd.c b/fs/reiser4/entd.c index a164f5a..355548d 100644 --- a/fs/reiser4/entd.c +++ b/fs/reiser4/entd.c @@ -218,7 +218,7 @@ void reiser4_leave_flush(struct super_block *super) #endif spin_unlock(&ent->guard); if (wake_up_ent) - wake_up(&ent->wait); + wake_up_process(ent->tsk); } #define ENTD_CAPTURE_APAGE_BURST SWAP_CLUSTER_MAX @@ -304,7 +304,7 @@ int write_page_by_ent(struct page *page, struct writeback_control *wbc) ent->nr_todo_reqs++; list_add_tail(&rq.link, &ent->todo_list); if (ent->nr_todo_reqs == 1) - wake_up(&ent->wait); + wake_up_process(ent->tsk); spin_unlock(&ent->guard);