From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KRBRf-0008Gp-UH
	for mharc-grub-devel@gnu.org; Thu, 07 Aug 2008 15:46:47 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KRBRe-0008E6-70
	for grub-devel@gnu.org; Thu, 07 Aug 2008 15:46:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KRBRb-00088v-NC
	for grub-devel@gnu.org; Thu, 07 Aug 2008 15:46:45 -0400
Received: from [199.232.76.173] (port=41118 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KRBRb-00088S-KB
	for grub-devel@gnu.org; Thu, 07 Aug 2008 15:46:43 -0400
Received: from mailout04.t-online.de ([194.25.134.18]:60969)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Christian.Franke@t-online.de>) id 1KRBRb-0005NJ-Ap
	for grub-devel@gnu.org; Thu, 07 Aug 2008 15:46:43 -0400
Received: from fwd28.aul.t-online.de by mailout04.sul.t-online.de with smtp 
	id 1KRBRZ-0006S1-01; Thu, 07 Aug 2008 21:46:41 +0200
Received: from [10.3.2.2]
	(ZSLM30Z-QhxAzOhhf3humeN9TKwmdCwsiJyHymfD88ghrI2gPunLye3FEyv+28SwIx@[217.235.250.31])
	by fwd28.aul.t-online.de
	with esmtp id 1KRBRM-1pmwlc0; Thu, 7 Aug 2008 21:46:28 +0200
Message-ID: <489B5114.7070201@t-online.de>
Date: Thu, 07 Aug 2008 21:46:28 +0200
From: Christian Franke <Christian.Franke@t-online.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <489B159A.2000106@t-online.de> <87hc9wssed.fsf@xs4all.nl>
In-Reply-To: <87hc9wssed.fsf@xs4all.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-ID: ZSLM30Z-QhxAzOhhf3humeN9TKwmdCwsiJyHymfD88ghrI2gPunLye3FEyv+28SwIx
X-TOI-MSGID: b226d576-fdc2-4959-b62f-260f3e9ea3af
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Fix infinite loop in grub_pit_wait()
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Aug 2008 19:46:46 -0000

Marco Gerards wrote:
> Christian Franke <Christian.Franke@t-online.de> writes:
>
> ...
>> 	(grub_pit_wait): Add enable/disable of the timer2 gate
>> 	bit of port 0x61. This fixes a possible infinite loop.
>>     
>
> Small nitpick: use a double space
>
>   
>> ...
>> +
>> +  /* Disable timer2 gate and speaker.  */
>> +  grub_outb (grub_inb (TIMER2_REG_LATCH) & ~ (TIMER2_SPEAKER | TIMER2_GATE), TIMER2_REG_LATCH);
>>     
> These lines are too long, please break them properly.
>
>   

Included in commit. Thanks.

Christian