Re: [PATCH] sound/pci/cs46xx/cs46xx_lib.c: remove unused variable

[Benoit Fouet <benoit.fouet@purplelabs.com>]

Hi,

Michael Borisov wrote:
> This patch fixes the following compile warning:
> sound/pci/cs46xx/cs46xx_lib.c: In function ‘snd_cs46xx_resume’:
> sound/pci/cs46xx/cs46xx_lib.c:3614: warning: unused variable ‘i’
>
>  cs46xx_lib.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Signed-off-by: Michael Borisov <niro@tut.by>
> ---
> diff --git a/sound/pci/cs46xx/cs46xx_lib.c
> b/sound/pci/cs46xx/cs46xx_lib.c
> index e214e56..07bb7e0 100644
> --- a/sound/pci/cs46xx/cs46xx_lib.c
> +++ b/sound/pci/cs46xx/cs46xx_lib.c
> @@ -3611,7 +3611,7 @@ int snd_cs46xx_resume(struct pci_dev *pci)
>  {
>  	struct snd_card *card = pci_get_drvdata(pci);
>  	struct snd_cs46xx *chip = card->private_data;
> -	int i, amp_saved;
> +	int amp_saved;
>  
>  	pci_set_power_state(pci, PCI_D0);
>  	pci_restore_state(pci);
> @@ -3633,6 +3633,7 @@ int snd_cs46xx_resume(struct pci_dev *pci)
>  #ifdef CONFIG_SND_CS46XX_NEW_DSP
>  	cs46xx_dsp_resume(chip);
>  	/* restore some registers */
> +	int i;
>   

why not ifdef'ing the declaration earlier.
doing it the way you are way, you mix declaration and code.
(I don't know what the kernel policy is for this matter)

-- 
Benoit Fouet
Purple Labs S.A.
www.purplelabs.com