All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Shishkin <edward.shishkin@gmail.com>
To: Ryan Hope <rmh3093@gmail.com>
Cc: reiserfs-devel@vger.kernel.org
Subject: Re: [reiser4] Point
Date: Sat, 09 Aug 2008 00:47:44 +0400	[thread overview]
Message-ID: <489CB0F0.8020806@gmail.com> (raw)
In-Reply-To: <489B44FD.5000108@gmail.com>

Ryan Hope wrote:
> Is this todo really done?

nop

>
> >> As in point 6. in todo list (pub.namesys.com/Reiser4/ToDo ) try to
> >> replace wake_up() with wake_up_process()
>
> There are still a few more wake_up()'s in the code, the following
> patch takes care of 2 of them.

 both are not obvious for me, review is needed..

Edward.

>
> diff --git a/fs/reiser4/entd.c b/fs/reiser4/entd.c
> index a164f5a..355548d 100644
> --- a/fs/reiser4/entd.c
> +++ b/fs/reiser4/entd.c
> @@ -218,7 +218,7 @@ void reiser4_leave_flush(struct super_block *super)
>  #endif
>      spin_unlock(&ent->guard);
>      if (wake_up_ent)
> -        wake_up(&ent->wait);
> +        wake_up_process(ent->tsk);
>  }
>
>  #define ENTD_CAPTURE_APAGE_BURST SWAP_CLUSTER_MAX
> @@ -304,7 +304,7 @@ int write_page_by_ent(struct page *page, struct
> writeback_control *wbc)
>      ent->nr_todo_reqs++;
>      list_add_tail(&rq.link, &ent->todo_list);
>      if (ent->nr_todo_reqs == 1)
> -        wake_up(&ent->wait);
> +        wake_up_process(ent->tsk);
>
>      spin_unlock(&ent->guard);
>
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe
> reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


  reply	other threads:[~2008-08-08 20:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <558.1643-13003-1386678025-1217242012@post.cz>
2008-07-28 14:31 ` kernel BUG at fs/reiser4/plugin/item/ctail.c Edward Shishkin
2008-08-04 10:28   ` Dushan Tcholich
2008-08-04 14:47     ` Edward Shishkin
2008-08-04 14:57       ` Dushan Tcholich
2008-08-04 16:50         ` Edward Shishkin
2008-08-04 21:57           ` Dushan Tcholich
2008-08-04 22:51             ` Volker Armin Hemmann
2008-08-05 20:31               ` Edward Shishkin
2008-08-05 12:42             ` Mr. Tao
2008-08-07 18:54             ` [reiser4] Point Ryan Hope
2008-08-08 20:47               ` Edward Shishkin [this message]
2008-08-09 15:03                 ` Ryan Hope
2008-08-12 18:58                   ` Edward Shishkin
2008-08-12 20:05                     ` Matthew
2008-08-12 20:47                       ` Edward Shishkin
2008-08-13  8:43                         ` Matthew
2008-08-13  9:57                           ` Edward Shishkin
2008-08-13 15:03                             ` Ryan Hope
2008-08-13 15:59                               ` Alli Quaknaa
2008-08-13 16:28                                 ` Ryan Hope
2008-08-13 16:33                                   ` Alli Quaknaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489CB0F0.8020806@gmail.com \
    --to=edward.shishkin@gmail.com \
    --cc=reiserfs-devel@vger.kernel.org \
    --cc=rmh3093@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.