Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree

[Rene Herman <rene.herman@keyaccess.nl>]

On 08-08-08 23:44, Yinghai Lu wrote:

> On Fri, Aug 8, 2008 at 2:28 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
>> On Fri, 8 Aug 2008 14:13:29 -0700
>> "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>>
>>>> commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped
>>>> debugging printks in arch/x86/kernel/mppparse.c into regular ones.  The
>>>> one at the top of smp_scan_config() in particular also prints on
>>>> !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything
>>>> resembling MP tables which makes their lowly UP owners wonder...
>>>>
>>>> Given that it was up to this point also not considered valuable user-level
>>>> information, let's just kill that one.
>>>>
>>> why?  that just three lines debug debug info.
>> For the reasons described in the changelog text.  They look quite valid
>> to me.
> 
> then how about system do have mptable ?

Those print:

   printk(KERN_INFO "found SMP MP-table at [%p] %08lx\n",
                                  mpf, virt_to_phys(mpf));

a few lines down. Note moreover that is used to be a "Dprintk()" which 
was defined to <nop> before -- ie, no change.

Rene.