All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Chr <chunkeey@web.de>
Cc: John W Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] p54: Fix for TX sequence number problem that resulted from commit 741b4fbc44
Date: Sun, 10 Aug 2008 09:19:10 -0500	[thread overview]
Message-ID: <489EF8DE.5030801@lwfinger.net> (raw)
In-Reply-To: <200808082038.48840.chunkeey@web.de>

Chr wrote:
> the next one is at line 27188... and so down to end of packages at line 329241.
> there isn't one single package where the sequence number is not zero!
> 
> So the problem must be somewhere else! what happens when:
> if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
> 	if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
> 		priv->seqno += 0x10;
> 
> 	ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
> 	ieee80211hdr->seq_ctrl |= cpu_to_le16(priv->seqno);
> 	ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
> }
> (yeah a new definition for idiotic! but it's about the same amount of of clock cycles).

There must be some situation where the firmware fails to assign a 
proper sequence number to some packets. With this patch in place, the 
device failed after 2 hours. Restoring my original patch, it has been 
up for 15 hours and still going.

Larry


  parent reply	other threads:[~2008-08-10 14:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-05 16:23 [PATCH] p54: Fix for TX sequence number problem that resulted from commit 741b4fbc44 Larry Finger
2008-08-08  8:26 ` Chr
2008-08-08 14:29   ` Larry Finger
2008-08-08 18:38     ` Chr
2008-08-09 16:02       ` Larry Finger
2008-08-09 16:43         ` Chr
2008-08-09 18:11           ` Larry Finger
2008-08-10 14:19       ` Larry Finger [this message]
2008-08-10 22:27         ` Chr
2008-08-10 23:04           ` Larry Finger
2008-08-13 22:15             ` Chr
2008-08-15 18:34         ` Chr
2008-08-15 19:26           ` Johannes Berg
2008-08-15 20:15             ` Chr
2008-08-15 20:17               ` Johannes Berg
2008-08-15 21:06                 ` Chr
2008-08-15 21:13                   ` Johannes Berg
2008-08-16  0:34           ` Larry Finger
2008-08-16  2:21             ` Chr
2008-08-16 14:00               ` Larry Finger
2008-08-16 14:38                 ` Chr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489EF8DE.5030801@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chunkeey@web.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.