From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D156D1A9 for ; Thu, 18 Apr 2024 06:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.110 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713421019; cv=none; b=EdZaLHXeTP7IcVSj0KUh4VmxofppGO2+GbDOZKMJyp/G5xKwMYW1Uz+vU31WGBqgJVd9J9NmmuO4IieHjBVsIHAFrhmVvuGUZfMue8CoZPSp9L67IpwSgz9b94ph4FX3P0sJdEcNQXvRj2928gwHIuHaYKmbL/GN9eB5cfMVa+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713421019; c=relaxed/simple; bh=sfKMRCoV3uYUY+fjwm+vNf8dFa9IjLvdYNmcE4P9Rso=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XNJW+uPLq8tByE5M0ENnyUIjouFKYpBy4N9MUCxHbssJmyUA4zM84/3VzKnvJJmj/ToI764yNE+ZFtR9kr/EWgqQOfiKpJhnQfzv1joWIOwO7/dWD6WwmRFdlARgce/8wwLmtgl/v9noMAAZ6Ij6CJaLap4AlbxXvCkUEEJrrJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=UQ6jU32S; arc=none smtp.client-ip=115.124.30.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="UQ6jU32S" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713421013; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=CktXo0hCwnR+bJh4SQAZ025qumYDIGNYgT2zhfl2Xf0=; b=UQ6jU32SeD4Cu3PNH6D0wuPkKjpNNhdjzoEvxk7OfCOYnhbl4iQyYpG90U56vrtfuAHp1Ucu7EcNAj+E37USYPEJlNcQqZI5ja3vuBcpuMvwM1v4f5YomUi4dwBdq8wK2wgCewLJYk47tl5+nSBht4vhnpjk4HOlZXY0fJT24t8= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=dtcccc@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0W4nYs5o_1713421011; Received: from 30.97.48.213(mailfrom:dtcccc@linux.alibaba.com fp:SMTPD_---0W4nYs5o_1713421011) by smtp.aliyun-inc.com; Thu, 18 Apr 2024 14:16:52 +0800 Message-ID: <489a558f-8f56-4342-9396-544a4b8ff8c3@linux.alibaba.com> Date: Thu, 18 Apr 2024 14:16:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] sched/eevdf: Return leftmost entity in pick_eevdf() if no eligible entity is found Content-Language: en-US To: Chen Yu Cc: Xuewen Yan , Peter Zijlstra , Abel Wu , Ingo Molnar , Vincent Guittot , Juri Lelli , Tim Chen , Tiwei Bie , Honglei Wang , Aaron Lu , Chen Yu , Yujie Liu , linux-kernel@vger.kernel.org, kernel test robot References: From: Tianchen Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/4/18 13:52, Chen Yu wrote: > On 2024-04-18 at 11:37:31 +0800, Tianchen Ding wrote: >> Hi, we've found a bug about reweight_eevdf(). Would you also please try this >> patchset? >> >> https://lore.kernel.org/all/20240306022133.81008-1-dtcccc@linux.alibaba.com/ >> > > Sure, I'll have a try after I test Xuewen's patch. I assume your fix is mainly in > 2/2 which adjusts the se->vruntime in reweight_eevdf() by using the correct > avg_vruntime(), although it might not be directly related to the s64 overflow issue > here, it is worthy a fix. > Yes. I'm hoping to reduce "noises" about the unexpected avg_vruntime() varying during your tests. Thanks.