From: yajun.deng@linux.dev
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: sock: add the case if sk is NULL
Date: Mon, 09 Aug 2021 06:12:55 +0000 [thread overview]
Message-ID: <489e6f1ce9f8de6fd8765d82e1e47827@linux.dev> (raw)
In-Reply-To: <20210806061136.54e6926e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
August 6, 2021 9:11 PM, "Jakub Kicinski" <kuba@kernel.org> wrote:
> On Fri, 6 Aug 2021 14:38:15 +0800 Yajun Deng wrote:
>
>> Add the case if sk is NULL in sock_{put, hold},
>> The caller is free to use it.
>>
>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>
> The obvious complaint about this patch (and your previous netdev patch)
> is that you're spraying branches everywhere in the code. Sure, it may
Sorry for that, I'll be more normative in later submission.
> be okay for free(), given how expensive of an operation that is but
> is having refcounting functions accept NULL really the best practice?
>
> Can you give us examples in the kernel where that's the case?
0 include/net/neighbour.h neigh_clone()
1 include/linux/cgroup.h get_cgroup_ns() and put_cgroup_ns() (This is very similar to my submission)
2 include/linux/ipc_namespace.h get_ipc_ns()
3 include/linux/posix_acl.h posix_acl_dup()
4 include/linux/pid.h get_pid()
5 include/linux/user_namespace.h get_user_ns()
next prev parent reply other threads:[~2021-08-09 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 6:38 [PATCH net-next] net: sock: add the case if sk is NULL Yajun Deng
2021-08-06 13:11 ` Jakub Kicinski
2021-08-09 6:12 ` yajun.deng [this message]
2021-08-09 9:34 ` Eric Dumazet
2021-08-09 10:28 ` Leon Romanovsky
2021-08-09 9:15 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489e6f1ce9f8de6fd8765d82e1e47827@linux.dev \
--to=yajun.deng@linux.dev \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.