All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dbaryshkov@gmail.com>
To: Takashi Iwai <tiwai@suse.de>,
	Dmitry Baryshkov <dbaryshkov@gmail.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] wm8750: add missing VREF output
Date: Mon, 11 Aug 2008 18:16:28 +0400	[thread overview]
Message-ID: <48A049BC.80609@gmail.com> (raw)
In-Reply-To: <20080811104204.GC5560@sirena.org.uk>

Hi,

Mark Brown wrote:
> On Mon, Aug 11, 2008 at 12:37:45PM +0200, Takashi Iwai wrote:
> 
>> You mean both patches (spitz: MONO -> MONO1 and wm8750: add missing
>> VREF)?  Anyway, a bit more detailed changelog is needed - what's
>> broken in the real use and how fixed.
> 
> The long description is exactly what's broken - the names are wrong or
> undeclared and since DAPM works based on the control names this causes
> the drivers to fail to initialise DAPM for the device concerned.  It's
> pretty much equivalent to C code referencing an undeclared variable.
> 

I saw these patches got merged into asoc/dev tree. Should I repost them 
with more descriptive changelog, or are them suitable as is?

-- 
With best wishes
Dmitry

  parent reply	other threads:[~2008-08-11 14:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-11  8:45 [PATCH 1/2] spitz: MONO -> MONO1 Dmitry Baryshkov
2008-08-11  8:45 ` [PATCH 2/2] wm8750: add missing VREF output Dmitry Baryshkov
2008-08-11  9:11   ` Mark Brown
2008-08-11  9:11     ` Dmitry Baryshkov
2008-08-11 10:19       ` Mark Brown
2008-08-11 10:37         ` Takashi Iwai
2008-08-11 10:42           ` Mark Brown
2008-08-11 10:45             ` Takashi Iwai
2008-08-11 11:01               ` Mark Brown
2008-08-11 11:36                 ` Takashi Iwai
2008-08-11 11:47                   ` Mark Brown
2008-08-11 14:16             ` Dmitry Baryshkov [this message]
2008-08-11 15:08               ` Takashi Iwai
2008-08-11  9:04 ` [PATCH 1/2] spitz: MONO -> MONO1 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A049BC.80609@gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.