All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes
Date: Mon, 11 Aug 2008 11:47:03 -0500	[thread overview]
Message-ID: <48A06D07.60103@codemonkey.ws> (raw)
In-Reply-To: <48A06B12.5000701@qumranet.com>

Avi Kivity wrote:
>
> You lose the switch(nb_args) in monitor_handle_command() so it comes 
> out even.  You don't need to cast anything -- though you do need to 
> change all the callbacks to accept an argument array.

And to either explicitly cast each argument or explicitly parse each 
argument.  It touches quite a bit of places in the code and makes the 
callbacks quite a bit more complicated.

Using a void * is a one line change and works on all modern systems.  
Seems like a winner to me :-)

Regards,

Anthony Liguori

  reply	other threads:[~2008-08-11 16:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 17:22 [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes Blue Swirl
2008-08-09 18:24 ` Anthony Liguori
2008-08-10 18:33   ` Blue Swirl
2008-08-11  7:52     ` Gerd Hoffmann
2008-08-11  9:54       ` Samuel Thibault
2008-08-11 13:32         ` M. Warner Losh
2008-08-11 13:30       ` M. Warner Losh
2008-08-11 14:21     ` Anthony Liguori
2008-08-11 14:48       ` Avi Kivity
2008-08-11 14:53         ` Paul Brook
2008-08-11 14:56         ` Laurent Vivier
2008-08-11 14:56         ` Anthony Liguori
2008-08-11 16:38           ` Avi Kivity
2008-08-11 16:47             ` Anthony Liguori [this message]
2008-08-11 18:52               ` Blue Swirl
2008-08-11 18:57                 ` Laurent Vivier
2008-08-11 19:11                   ` Blue Swirl
2008-08-11 19:22                   ` Anthony Liguori
2008-08-11 20:03                     ` Laurent Vivier
2008-08-12  1:57                       ` Anthony Liguori
2008-08-12  8:14                         ` Laurent Vivier
2008-08-12  9:22                         ` Avi Kivity
2008-08-12 12:24                     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A06D07.60103@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.