From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com
Subject: Re: [Qemu-devel] [PATCH 01/11] Handle terminating signals.
Date: Mon, 11 Aug 2008 21:52:54 +0200 [thread overview]
Message-ID: <48A09896.60807@redhat.com> (raw)
In-Reply-To: <48A09296.2040406@codemonkey.ws>
Anthony Liguori wrote:
>> --- a/sdl.c
>> +++ b/sdl.c
>> @@ -476,10 +476,8 @@ static void sdl_refresh(DisplayState *ds)
>> sdl_process_key(&ev->key);
>> break;
>> case SDL_QUIT:
>> - if (!no_quit) {
>> + if (!no_quit)
>> qemu_system_shutdown_request();
>> - vm_start(); /* In case we're paused */
>>
>
> I'm curious why this is no longer needed?
To avoid calling vm_start() from the signal handler main_loop() got an
additional check so qemu_system_shutdown_request() works even when the
vm is in stopped state.
[ Hmm, cut&paste -> changelog I guess ... ]
cheers,
Gerd
--
http://kraxel.fedorapeople.org/xenner/
next prev parent reply other threads:[~2008-08-11 19:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 12:32 [Qemu-devel] [PATCH 00/11] merge some xen bits into qemu Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 01/11] Handle terminating signals Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 19:27 ` [Qemu-devel] " Anthony Liguori
2008-08-11 19:52 ` Gerd Hoffmann [this message]
2008-08-11 19:30 ` Anthony Liguori
2008-08-11 19:58 ` Gerd Hoffmann
2008-08-12 1:53 ` Anthony Liguori
2008-08-11 12:32 ` [Qemu-devel] [PATCH 02/11] add DisplayState->idle Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:36 ` [Qemu-devel] " Samuel Thibault
2008-08-11 12:36 ` Samuel Thibault
2008-08-11 12:32 ` [Qemu-devel] [PATCH 03/11] add container_of() macro to osdep.h Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 04/11] move GUI_REFRESH_INTERVAL define from vl.c to console.h Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 05/11] xen: groundwork for xen support Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 06/11] xen: backend driver core Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 07/11] xen: add console backend driver Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 08/11] xen: add framebuffer " Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 09/11] xen: add block device " Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 10/11] xen: add net " Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
2008-08-11 12:32 ` [Qemu-devel] [PATCH 11/11] xen: blk & nic configuration via cmd line Gerd Hoffmann
2008-08-11 12:32 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A09896.60807@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.