From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KSfFn-0004nS-PI for mharc-grub-devel@gnu.org; Mon, 11 Aug 2008 17:48:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSfFl-0004ks-Ue for grub-devel@gnu.org; Mon, 11 Aug 2008 17:48:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSfFk-0004ij-Hf for grub-devel@gnu.org; Mon, 11 Aug 2008 17:48:37 -0400 Received: from [199.232.76.173] (port=49420 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSfFk-0004iX-9J for grub-devel@gnu.org; Mon, 11 Aug 2008 17:48:36 -0400 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]:4481) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KSfFj-0004rD-Qx for grub-devel@gnu.org; Mon, 11 Aug 2008 17:48:36 -0400 Received: from [192.168.1.2] (sander-marechal.xs4all.nl [82.95.221.82]) (authenticated bits=0) by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7BLmXwv092668 for ; Mon, 11 Aug 2008 23:48:33 +0200 (CEST) (envelope-from s.marechal@jejik.com) Message-ID: <48A0B3B1.6010507@jejik.com> Date: Mon, 11 Aug 2008 23:48:33 +0200 From: Sander Marechal User-Agent: Icedove 1.5.0.14eol (X11/20080724) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080808202337.3440.57502.reportbug@sylvester.jejik.com.jejik.com> <1218277583.9301.6.camel@fz.local> <489EEAC5.4080209@jejik.com> <1218471512.6939.19.camel@fz.local> In-Reply-To: <1218471512.6939.19.camel@fz.local> X-Enigmail-Version: 0.94.4.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 21:48:38 -0000 Felix Zielcke wrote: > Well attached is now my cute little asprintf patch with a very ugly LVM > part. > > It works for > > volumegroup: linuxvg > logicalvolume: lvol0 > /dev/mapper/linuxvg-lvol0 > > volume group: m-y--vg > logical volume: l-vol--0 > /dev/mapper/m--y----vg-l--vol----0 > > > Please comment this, please give me hints how to make it better. > I don't like the code myself but it seems like we should handle this > double dash problem :( I commented on this on #grub but will post here as well, to preserve it for posterity :-) I tested the patch against grub 20080724 in Debian Lenny and it works great :-) I can't comment on the rest of the code. I'm not a grub developer. -- Sander Marechal