All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Hope <rmh3093@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Edward Shishkin <edward.shishkin@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Reiserfs mailing list <reiserfs-devel@vger.kernel.org>
Subject: [PATCH 3/3][reiser4] dont get radix-tree dirty tagging out of sync
Date: Mon, 11 Aug 2008 18:40:09 -0400	[thread overview]
Message-ID: <48A0BFC9.40502@gmail.com> (raw)

This was item #14 on the todo list for reiser4 inclusion in mainline:

diff --git a/fs/reiser4/page_cache.c b/fs/reiser4/page_cache.c
index fe71368..a662c25 100644
--- a/fs/reiser4/page_cache.c
+++ b/fs/reiser4/page_cache.c
@@ -467,15 +467,14 @@ int reiser4_set_page_dirty_internal(struct page *page)
  	BUG_ON(mapping == NULL);

  	if (!TestSetPageDirty(page)) {
+		spin_lock_irq(&mapping->tree_lock);
  		if (mapping_cap_account_dirty(mapping))
  			inc_zone_page_state(page, NR_FILE_DIRTY);
-
+		radix_tree_tag_set(&mapping->page_tree,
+			page_index(page), PAGECACHE_TAG_DIRTY);
  		__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
+		spin_unlock_irq(&mapping->tree_lock);
  	}
-
-	/* znode must be dirty ? */
-	if (mapping->host == reiser4_get_super_fake(mapping->host->i_sb))
-		assert("", JF_ISSET(jprivate(page), JNODE_DIRTY));
  	return 0;
  }

-Ryan

             reply	other threads:[~2008-08-11 22:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-11 22:40 Ryan Hope [this message]
2008-08-12  2:36 ` [PATCH 3/3][reiser4] dont get radix-tree dirty tagging out of sync Nick Piggin
2008-08-12  4:12   ` Ryan Hope
2008-08-12  6:00     ` Nick Piggin
2008-08-12 14:52       ` Ryan Hope
2008-08-12 12:56   ` Edward Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A0BFC9.40502@gmail.com \
    --to=rmh3093@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=edward.shishkin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.