From: Max Krasnyansky <maxk@qualcomm.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4)
Date: Mon, 11 Aug 2008 20:27:43 -0700 [thread overview]
Message-ID: <48A1032F.4040606@qualcomm.com> (raw)
In-Reply-To: <b9df5fa10808112021v7bb48c9ejefab284bea82c837@mail.gmail.com>
Rakib Mullick wrote:
> One more thing Max, while you are allocating memory for "dattr" I
> think it needs to check that it is successful or not . I've shown it
> on one of my previous patch on 7th Aug.
I think you missed this part of the patch
> + /*
> + * The rest of the code, including the scheduler, can deal with
> + * dattr==NULL case. No need to abort if alloc fails.
> + */
> dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL);
I replied to your patch saying that we do not need to check it. And Paul
suggested to add a comment to explain why.
Max
next prev parent reply other threads:[~2008-08-12 3:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 21:33 [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4) Max Krasnyansky
2008-08-11 21:38 ` Max Krasnyansky
2008-08-12 3:21 ` Rakib Mullick
2008-08-12 3:27 ` Max Krasnyansky [this message]
[not found] ` <b9df5fa10808120501i57dbd71k71b54cca0bfb2ff2@mail.gmail.com>
2008-08-12 13:48 ` Rakib Mullick
2008-08-12 16:27 ` Paul Jackson
2008-08-12 16:39 ` Max Krasnyansky
2008-08-12 17:12 ` Rakib Mullick
2008-08-12 3:33 ` Paul Jackson
2008-08-11 23:31 ` Paul Jackson
2008-08-14 9:24 ` Ingo Molnar
2008-08-14 11:16 ` Ingo Molnar
2008-08-14 18:21 ` Max Krasnyansky
2008-08-20 6:44 ` [input layer, lockdep warning] " Ingo Molnar
2008-08-20 13:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A1032F.4040606@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.