From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yosuke Iwamatsu Subject: [PATCH] stubdom: Fix the Makefile Date: Tue, 12 Aug 2008 13:59:09 +0900 Message-ID: <48A1189D.7050609@ab.jp.nec.com> References: <4896D508.9000101@ab.jp.nec.com> <18592.6365.409636.426364@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18592.6365.409636.426364@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] stubdom: Fix the Makefile"): >> While building stubdom, I saw an error. >> >> install: cannot stat `lib/{config,header,pci,types}.h': No such file >> or directory >> >> It seems brace expansion is not available in some environments, so we >> had better avoid using it. > > I see that this has been committed already. However for future > reference I think a better answer is to say > SHELL=/bin/bash > in some appropriate place. > > This kind of brace expansion is an excellent trick for removing > duplication in Makefile runes and our build system depends on bash > anyway. I agree that brace expansion is convenient and sometimes desireble. One thing I want to clarify is that, does our build system really depend on bash? Non-linux systems as *BSD and Solaris are not likely to have bash, so 'SHELL=/bin/bash' won't work. (I usually use a linux box myself and assuming that bash is always available is O.K. to me, though.) -- Yosuke