From: Rene Herman <rene.herman@keyaccess.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@linuxfoundation.org, fritz@isdn4linux.de, kkeil@suse.de,
isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org,
mingo@elte.hu
Subject: Re: [PATCH] ISDN: make ICN not auto-grab port 0x320
Date: Tue, 12 Aug 2008 07:02:10 +0200 [thread overview]
Message-ID: <48A11952.6090203@keyaccess.nl> (raw)
In-Reply-To: <20080811164814.db41c20b.akpm@linux-foundation.org>
On 12-08-08 01:48, Andrew Morton wrote:
> otoh it's a bit sad to break allyesconfig kernels - there is
> regression-testing value in being able to run such kernels.
>
> I wonder if we can add a new boot option `allyesconfig-test' or
> something like that, and then, within the offending drivers, test that
> flag and take suitable avoiding action.
>
> Or we could do it at compile-time - define
> CONFIG_ALLYESCONFIG_TESTING in some fashion.
Yes, latter I'd feel with the thing most against it that there aren't
actually many that need it. Here's the list that was posted:
http://lkml.org/lkml/2008/8/1/96
Three legacy ISA driver from that list can now be stricken. Hurrah.
There's always going to be at least a few that'll remain though. For
example, what are you going to do with:
--- linux.orig/drivers/ide/Kconfig
+++ linux/drivers/ide/Kconfig
@@ -9,6 +9,11 @@ config HAVE_IDE
menuconfig IDE
tristate "ATA/ATAPI/MFM/RLL support"
depends on HAVE_IDE
+
+ # my test box expects /dev/sda, not /dev/hda
+ depends on BROKEN_BOOT_ALLOWED
+ select BROKEN_BOOT if IDE = y
+
depends on BLOCK
---help---
If you say Y here, your kernel will be able to manage low cost
The hda->sda thing was just a disaster -- personally I have to remember
to change things around till this very day before I boot into my distro
kernel to test things. I wouldn't be the one suggesting a patch to
drivers/ide to "fix" that though including really a patch to its Kconfig
marking it as breaking anything in a global way rather than a
user-specific way as was done here.
Maybe the test boxes should always boot with ide_core.noprobe=<all> for
a suitable value of <all> or some such...
Others are the video ones. FB_VESA, FB_VGA16FB and even MDA_CONSOLE are
in there which seems to imply some decidly non-legacy hardware and I
sort of doubt willingness to assume global validity of such a setup.
But yes, there is value in the testing so perhaps still worh something
generic.
(I'll continue some specific looking through the list first although I
don't believe there is much else that really wants specific fixing).
Rene.
next prev parent reply other threads:[~2008-08-12 5:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-09 17:39 [PATCH] ISDN: make ICN not auto-grab port 0x320 Rene Herman
2008-08-09 20:50 ` Alan Cox
2008-08-11 23:48 ` Andrew Morton
2008-08-12 5:02 ` Rene Herman [this message]
2008-08-12 5:30 ` Andrew Morton
2008-08-12 13:08 ` Adrian Bunk
2008-08-12 13:26 ` Rene Herman
2008-08-12 13:43 ` Adrian Bunk
2008-08-12 13:53 ` Rene Herman
2008-08-12 14:03 ` Adrian Bunk
2008-08-12 14:45 ` Rene Herman
2008-08-12 15:23 ` Adrian Bunk
2008-08-12 13:46 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A11952.6090203@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@linux-foundation.org \
--cc=akpm@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fritz@isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.