All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH,RFC 09/09] svcrdma: Update svc_rdma_send_error to use DMA LKEY
@ 2008-08-13 16:16 Tom Tucker
  0 siblings, 0 replies; only message in thread
From: Tom Tucker @ 2008-08-13 16:16 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: linux-nfs

Update the svc_rdma_send_error code to use the DMA LKEY which is valid
regardless of the memory registration strategy in use.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>

---
  net/sunrpc/xprtrdma/svc_rdma_transport.c |   11 +++++++++--
  1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index e75cb96..94f51da 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -1331,10 +1331,14 @@ void svc_rdma_send_error(struct svcxprt_rdma *xprt, struct rpcrdma_msg *rmsgp,
  	length = svc_rdma_xdr_encode_error(xprt, rmsgp, err, va);

  	/* Prepare SGE for local address */
-	atomic_inc(&xprt->sc_dma_used);
  	sge.addr = ib_dma_map_page(xprt->sc_cm_id->device,
  				   p, 0, PAGE_SIZE, DMA_FROM_DEVICE);
-	sge.lkey = xprt->sc_phys_mr->lkey;
+	if (ib_dma_mapping_error(xprt->sc_cm_id->device, sge.addr)) {
+		put_page(p);
+		return;
+	}
+	atomic_inc(&xprt->sc_dma_used);
+	sge.lkey = xprt->sc_dma_lkey;
  	sge.length = length;

  	ctxt = svc_rdma_get_context(xprt);
@@ -1355,6 +1359,9 @@ void svc_rdma_send_error(struct svcxprt_rdma *xprt, struct rpcrdma_msg *rmsgp,
  	if (ret) {
  		dprintk("svcrdma: Error %d posting send for protocol error\n",
  			ret);
+		ib_dma_unmap_page(xprt->sc_cm_id->device,
+				  sge.addr, PAGE_SIZE,
+				  DMA_FROM_DEVICE);
  		svc_rdma_put_context(ctxt, 1);
  	}
  }

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-13 16:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-13 16:16 [PATCH,RFC 09/09] svcrdma: Update svc_rdma_send_error to use DMA LKEY Tom Tucker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.