From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: khc@pm.waw.pl, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RESEND][PATCH 2.6.27-rc3] ixp4xx_eth: fix dma_mapping_error() compile errors
Date: Thu, 14 Aug 2008 04:28:46 -0400 [thread overview]
Message-ID: <48A3ECBE.9050909@garzik.org> (raw)
In-Reply-To: <200808131908.m7DJ8EAp013777@harpo.it.uu.se>
Mikael Pettersson wrote:
> The arm ixp4xx_eth driver doesn't compile in 2.6.27-rc1:
>
> CC [M] drivers/net/arm/ixp4xx_eth.o
> drivers/net/arm/ixp4xx_eth.c: In function 'eth_poll':
> drivers/net/arm/ixp4xx_eth.c:554: warning: passing argument 1 of 'dma_mapping_error' makes pointer from integer without a cast
> drivers/net/arm/ixp4xx_eth.c:554: error: too few arguments to function 'dma_mapping_error'
> drivers/net/arm/ixp4xx_eth.c: In function 'eth_xmit':
> drivers/net/arm/ixp4xx_eth.c:701: warning: passing argument 1 of 'dma_mapping_error' makes pointer from integer without a cast
> drivers/net/arm/ixp4xx_eth.c:701: error: too few arguments to function 'dma_mapping_error'
> drivers/net/arm/ixp4xx_eth.c: In function 'init_queues':
> drivers/net/arm/ixp4xx_eth.c:886: warning: passing argument 1 of 'dma_mapping_error' makes pointer from integer without a cast
> drivers/net/arm/ixp4xx_eth.c:886: error: too few arguments to function 'dma_mapping_error'
> make[3]: *** [drivers/net/arm/ixp4xx_eth.o] Error 1
> make[2]: *** [drivers/net/arm] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> dma_mapping_error() changed in 2.6.27-rc1 to also take a device parameter,
> but nobody bothered updating ixp4xx_eth.c. Fixed by passing the appropriate
> device value in the dma_mapping_error() calls.
>
> Tested on an ixp425 box.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
> ---
applied
next prev parent reply other threads:[~2008-08-14 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 19:08 [RESEND][PATCH 2.6.27-rc3] ixp4xx_eth: fix dma_mapping_error() compile errors Mikael Pettersson
2008-08-14 8:28 ` Jeff Garzik [this message]
2008-08-14 18:46 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A3ECBE.9050909@garzik.org \
--to=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.