All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
To: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: ARM Linux
	<linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org>,
	Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [RFC] PXA3xx: Add support for power i2c bus
Date: Thu, 14 Aug 2008 13:28:54 +0300	[thread overview]
Message-ID: <48A408E6.4000506@compulab.co.il> (raw)
In-Reply-To: <f17812d70808140202k2edd82dfhea421a649dea85d7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



Eric Miao wrote:
> On Thu, Aug 14, 2008 at 4:55 PM, Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org> wrote:
>> This patch adds support for power i2c bus on PXA3xx processor.
>>
>> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>>
> 
> I'd like the i2c driver to be converted to ioremap() and {read,write}l()
> first before this can happen.

It is already using {read,write}l() unless I'm realy missing something...


> pxa27x_set_i2c_power_info()
> 
> and
> 
> pxa3xx_set_i2c_power_info()
> 
> are OK to co-exist, no need for a unified version. IOW, I'd prefer
> the previous invocations of pxa_set_i2c_power_info() to be
> renamed "pxa27x_set_i2c_power_info()"

Ok.

> The caller is supposed to know which to call.
> 

-- 
Sincerely yours,
Mike.


_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

  parent reply	other threads:[~2008-08-14 10:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-14  8:55 [RFC] PXA3xx: Add support for power i2c bus Mike Rapoport
     [not found] ` <48A3F2EB.8030809-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2008-08-14  9:02   ` Eric Miao
     [not found]     ` <f17812d70808140202k2edd82dfhea421a649dea85d7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-14 10:28       ` Mike Rapoport [this message]
2008-08-14 10:39 ` Russell King - ARM Linux
2008-08-14 11:38   ` Mike Rapoport
2008-08-14 13:07     ` [i2c] " Ben Dooks
2008-08-14 13:43       ` Mike Rapoport
     [not found]         ` <48A43671.6000302-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2008-08-15  2:11           ` Eric Miao
2008-08-16  8:41         ` [i2c] " Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A408E6.4000506@compulab.co.il \
    --to=mike-utxizqzc01rs1mouv/rt9w@public.gmane.org \
    --cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.