From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KThNB-0005JB-LP
	for mharc-grub-devel@gnu.org; Thu, 14 Aug 2008 14:16:33 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KThNA-0005Ib-6n
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:16:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KThN8-0005Ha-JV
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:16:31 -0400
Received: from [199.232.76.173] (port=45154 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KThN8-0005HW-F6
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:16:30 -0400
Received: from mta-out.inet.fi ([195.156.147.13]:47902 helo=kirsi1.inet.fi)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1KThN8-0002iP-1T
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:16:30 -0400
Received: from [127.0.0.1] (88.193.32.97) by kirsi1.inet.fi (8.5.014)
	id 487B3C2C01310641 for grub-devel@gnu.org;
	Thu, 14 Aug 2008 21:16:29 +0300
Message-ID: <48A47683.1040809@nic.fi>
Date: Thu, 14 Aug 2008 21:16:35 +0300
From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <87fxp9di59.fsf@xs4all.nl>
	<20080812224041.GB3141@thorin>	<1218606980.4008.9.camel@fz.local>
	<87abfhb60p.fsf@xs4all.nl>	<1218659496.25595.7.camel@fz.local>
	<20080813215023.GA23069@thorin>	<1218667156.4010.5.camel@fz.local>	<1218670230.4010.11.camel@fz.local>
	<87vdy4yspn.fsf@xs4all.nl>	<1218711750.5154.11.camel@fz.local>
	<20080814180806.GA18309@thorin>
In-Reply-To: <20080814180806.GA18309@thorin>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Aug 2008 18:16:32 -0000

Robert Millan wrote:
> On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
>> +int
>> +grub_err_printf (const char *fmt, ...)
>> +{
>> +  va_list ap;
>> +  int ret;
>> +  
>> +  va_start (ap, fmt);
>> +  ret = vfprintf (stderr, fmt, ap);
>> +  va_end (ap);
>> +
>> +  return ret;
>> +}
>>  void *
>>  xmalloc (size_t size)
> 
> Please separate functions with an empty line.  Anyway, no need to send a new
> patch just for this.
> 
> Marco, is it fine to you now?
> 

Please use grub's own string formatter.