From: Bill Burns <bburns@redhat.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] Allow Hypervisor build with more than 64 CPUs
Date: Fri, 15 Aug 2008 15:26:27 -0400 [thread overview]
Message-ID: <48A5D863.6000000@redhat.com> (raw)
Trying to build the Xen hypervisor with max_phys_cpus=128
for x86_64 fails. (Note that this was on a 3.1 base, but
unstable appears to have the same issue).
There is a build assertion due to the size of
the page_info structure and the shadow_page_info
structures get out of sync due to the presence
of cpumask_t in the page info structure (which
grows with more than 64 CPUs).
The proposed fix is to tack on the following to
the end of shadow_page_info structure.
Kudo's to Eduardo Habkost for the workaround.
Signed-off-by: Bill Burns <bburns@redhat.com>
--- xen/arch/x86/mm/shadow/private.h.orig 2007-12-06 12:48:38.000000000 -0500
+++ xen/arch/x86/mm/shadow/private.h 2008-08-12 12:52:49.000000000 -0400
@@ -243,6 +243,12 @@ struct shadow_page_info
/* For non-pinnable shadows, a higher entry that points at us */
paddr_t up;
};
+#if NR_CPUS > 64
+ /* Need to add some padding to match struct page_info size,
+ * if cpumask_t is larger than a long
+ */
+ u8 padding[sizeof(cpumask_t)-sizeof(long)];
+#endif
};
next reply other threads:[~2008-08-15 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 19:26 Bill Burns [this message]
2008-08-17 10:23 ` [PATCH] Allow Hypervisor build with more than 64 CPUs Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A5D863.6000000@redhat.com \
--to=bburns@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.