All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven A. Falco <sfalco@harris.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] setting pio modes for IDE devices
Date: Fri, 15 Aug 2008 15:37:31 -0400	[thread overview]
Message-ID: <48A5DAFB.10007@harris.com> (raw)
In-Reply-To: <20080815181230.89BDB248CD@gemini.denx.de>

Wolfgang Denk wrote:
> Dear "Steven A. Falco",
> 
> In message <48A5C296.1060801@harris.com> you wrote:
>> I realized that I should be checking to see if word 163 is applicable to
>> the ATA device in question.  To do that, I need to call ata_id_is_cfa() from
>> libata.h.  However, libata.h conflicts with ata.h because of duplicate
>> enum values.
>>
>> Therefore, this respin of the proposed patch deletes the duplicate enums
>> from ata.h and instead includes libata.h to supply the enums.  Then, I
>> can call ata_id_is_cfa() and more accurately detect PIO 5 and 6.
>>
>> I believe cleaning up ata.h is a good thing, because duplicating the enums in
>> both places invites them to get out of sync.
> 
> It is, but can you please split this into two independent patches?
> 
> Thanks in advance.
> 
> Best regards,
> 
> Wolfgang Denk
> 

[PATCH 3/3] Typo in spelling of ATAPI.

Correct a small spelling mistake.

Signed-off-by: Steven A. Falco <sfalco@harris.com>
---
 common/cmd_ide.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/cmd_ide.c b/common/cmd_ide.c
index 0691007..a744b41 100644
--- a/common/cmd_ide.c
+++ b/common/cmd_ide.c
@@ -1822,7 +1822,7 @@ unsigned char atapi_issue(int device,unsigned char*
ccb,int ccblen, unsigned cha
 	c = atapi_wait_mask(device,ATAPI_TIME_OUT,mask,res);

 	if ((c & mask) != res) { /* DRQ must be 1, BSY 0 */
-		printf ("ATTAPI_ISSUE: Error (no IRQ) before sending ccb dev %d status
0x%02x\n",device,c);
+		printf ("ATAPI_ISSUE: Error (no IRQ) before sending ccb dev %d status
0x%02x\n",device,c);
 		err=0xFF;
 		goto AI_OUT;
 	}
-- 
1.5.5.1

  parent reply	other threads:[~2008-08-15 19:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 21:42 [U-Boot] [RFC] setting pio modes for IDE devices Steven A. Falco
2008-08-13 23:20 ` Wolfgang Denk
2008-08-14 14:33   ` Steven A. Falco
2008-08-14 16:42     ` Jean-Christophe PLAGNIOL-VILLARD
2008-08-15 15:23       ` Steven A. Falco
2008-08-15 17:53         ` Steven A. Falco
2008-08-15 18:12           ` Wolfgang Denk
2008-08-15 19:29             ` [U-Boot] [Patch 1/3] " Steven A. Falco
2008-08-20 23:21               ` Wolfgang Denk
2008-08-15 19:34             ` [U-Boot] [PATCH 2/3] " Steven A. Falco
2008-08-20 23:31               ` Wolfgang Denk
2008-08-15 19:37             ` Steven A. Falco [this message]
2008-08-20 23:33               ` [U-Boot] [PATCH 3/3] " Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A5DAFB.10007@harris.com \
    --to=sfalco@harris.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.