From: Andi Kleen <ak@linux.intel.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>, gregkh <greg@kroah.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: linux-next: Tree for August 14 (sysfs/acpi errors)
Date: Sat, 16 Aug 2008 04:57:57 +0200 [thread overview]
Message-ID: <48A64235.2030108@linux.intel.com> (raw)
In-Reply-To: <1218854219.3629.30.camel@lgn.site>
>> Extract is:
>>
>> XXX adding modparam:'acpi.power_nocheck' 34 (ffffffff806a4cf0)
> ...
>> XXX adding modparam:'acpi.acpica_version' 45 (ffffffff806a4ea8)
>
> Two different "modules" use the same prefix, which does not work with
> the current logic, they need to live next to each other in the sequence
> of options.
Sequence of options being defined by link order?
> This adds a new option:
> http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=1382827e93799ec07790849e361267993cfe549e
> which specifies MODULE_PARAM_PREFIX="acpi." in:
> drivers/acpi/power.c
> In the same way as:
> drivers/acpi/system.c
>
> Seems, two different modules should not declare parameters in different
> locations, and use the same MODULE_PARAM_PREFIX.
That seems bogus to me. Assuming we have some code in a module and then split
it out into two different modules. Or move an option from one file to another.
Would we need to change the option name then?
I think the generic params code should be fixed to handle this.
-Andi
next prev parent reply other threads:[~2008-08-16 2:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 7:29 linux-next: Tree for August 14 Stephen Rothwell
2008-08-14 9:16 ` Geert Uytterhoeven
2008-08-14 15:34 ` linux-next: Tree for August 14 (bug: cciss) Randy Dunlap
2008-08-14 15:38 ` linux-next: Tree for August 14 (sysfs/acpi errors) Randy Dunlap
2008-08-14 15:44 ` Greg KH
2008-08-15 2:56 ` Andi Kleen
2008-08-15 3:09 ` Zhang Rui
2008-08-15 3:11 ` Andi Kleen
2008-08-15 2:41 ` Zhang Rui
2008-08-15 2:46 ` Randy Dunlap
2008-08-15 11:27 ` Kay Sievers
2008-08-15 15:58 ` Randy Dunlap
2008-08-16 2:36 ` Kay Sievers
2008-08-16 2:57 ` Andi Kleen [this message]
2008-08-16 3:19 ` Kay Sievers
2008-08-16 3:48 ` Andi Kleen
2008-08-16 4:47 ` Greg KH
2008-08-16 4:47 ` Greg KH
2008-08-17 2:30 ` Andi Kleen
2008-08-17 2:30 ` Andi Kleen
2008-08-17 3:40 ` Greg KH
2008-08-17 3:40 ` Greg KH
2008-08-17 3:53 ` Andi Kleen
2008-08-18 3:48 ` Greg KH
2008-08-18 9:43 ` Rusty Russell
2008-08-18 10:58 ` Kay Sievers
2008-08-17 5:13 ` Rusty Russell
2008-09-24 7:59 ` Len Brown
2008-09-25 2:39 ` Rusty Russell
2008-08-16 3:47 ` Rusty Russell
2008-08-16 3:49 ` Andi Kleen
2008-08-16 5:25 ` Sam Ravnborg
2008-08-16 5:56 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A64235.2030108@linux.intel.com \
--to=ak@linux.intel.com \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.