From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFC] Platform information services
Date: Sat, 16 Aug 2008 10:03:15 +0300 [thread overview]
Message-ID: <48A67BB3.3020403@nic.fi> (raw)
In-Reply-To: <48A6057C.6010704@isaac.cedarswampstudios.org>
Isaac Dupree wrote:
> if you rely on a property of the kernel, you should document it
> somewhere in the kernel, and document everyone (hopefully) who relies on
> that property; or the users could have some symbol in the source that
> you can search for. It doesn't have to be a function that takes up any
> actual kernel disk-space.
Function name is kinda good symbol. Magic numbers without defines are
not used really on GRUB 2 code base, if they are then there is omission
and that should be fixed. Every good editor allows you to allow fast
walking on source code based on symbols.
But I am against documenting into kernel who use what. It is doomed to
be outdated easily and that information is easily available when using
decent editor.
Of course you should document what code does.
next prev parent reply other threads:[~2008-08-16 7:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 3:36 [RFC] Platform information services Javier Martín
2008-08-14 16:09 ` Vesa Jääskeläinen
2008-08-14 16:38 ` Javier Martín
2008-08-14 17:41 ` Vesa Jääskeläinen
2008-08-14 21:45 ` Javier Martín
2008-08-14 18:00 ` Robert Millan
2008-08-14 21:29 ` Javier Martín
2008-08-15 16:31 ` Vesa Jääskeläinen
2008-08-15 17:03 ` Javier Martín
2008-08-15 17:14 ` Vesa Jääskeläinen
2008-08-15 17:59 ` Javier Martín
2008-08-15 18:35 ` Vesa Jääskeläinen
2008-08-15 19:18 ` Javier Martín
2008-08-15 19:46 ` Vesa Jääskeläinen
2008-08-15 20:13 ` Javier Martín
2008-08-15 20:26 ` Vesa Jääskeläinen
2008-08-15 22:38 ` Isaac Dupree
2008-08-15 23:06 ` Javier Martín
2008-08-16 7:03 ` Vesa Jääskeläinen [this message]
2008-08-16 12:20 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A67BB3.3020403@nic.fi \
--to=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.