Re: [PATCH, RFC] ext4: flex_bg ialloc, don't pick "best_flex" with 0 inodes

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:
> On Fri, Aug 15, 2008 at 05:01:10PM -0500, Eric Sandeen wrote:
>> It seems like adjusting the following test is a better plan;
>> for starters I do not see that best_flex can ever be < 0, so
> 
> Given that ext4_group_t is an unsigned long, that's certainly true.
> :-)

Heh, that too!

>> that test is replaced, and if the current "best" flex group
>> has no inodes free, and the current one does have room,
>> it is promoted to the next "best."
> 
> Looks good to me.  I've added it to the patch queue.
> 
>> Signed-of-by: Eric Sandeen <sandeen@redhat.com>
> 
> (forgot an 'f' :-)

Urk...

Thanks!

-Eric

> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> 
> 					- Ted