Re: [Xenomai-core] [PATCH] can: avoid naming conflict in 2.6.26

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

Wolfgang Grandegger wrote:
> Paul wrote:
>> On Wednesday 13 August 2008, Jan Kiszka wrote:
>>> Wolfgang Grandegger wrote:
>>>> Hi Jan,
>>>>
>>>> Jan Kiszka wrote:
>>>>> Due to a global definition of 'clock' in latest 2.6.26, we now have a
>>>>> problem with two rtcan drivers. Below is a fix that breaks those
>>>>> drivers' user interface by rename the conflicting variable which
>>>>> unfortunately also renames the module parameter name.
>>>>>
>>>>> An alternative approach would be to add a kernel version dependent fix
>>>>> to the drivers. That would be required as compat_module_param_array
>>>>> cannot be extended to use a different parameter name than the related
>>>>> variable is called. Maybe someone sees a third, better solution, I do
>>>>> not.
>>>> Nor do I. But I would prefer prefixing the module parameters with
>>>> "can_". Who knows what comes next.
>>> The issue is still open. Wolfgang, will you take care?
> 
> Didn't find time yet to fix it, sorry.
> 
>>> Jan
>> Just bringing the issue back to the top (had to fix locally before compiling 
>> 2.6.26.2).
>>
>>  Attached, a patch in line with Wolfgang's recommendation - Also includes a 
>> trivial spelling correction.
> 
> Your patch looks good.
> 

OK, finally committed.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]