From: Rene Herman <rene.herman@keyaccess.nl>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] wss_lib: snd_wss_calibrate_mute improvement
Date: Mon, 18 Aug 2008 10:50:15 +0200 [thread overview]
Message-ID: <48A937C7.2040600@keyaccess.nl> (raw)
In-Reply-To: <20080817223827.d3250ef5.krzysztof.h1@poczta.fm>
On 17-08-08 22:38, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> Mute sound by setting mute bit without
> setting volume to 0. It makes both source code
> and binary shorter.
>
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Grmmbbled-over-by: Rene Herman <rene.herman@gmail.com>
This should be safe and the current function indeed generates crap code
but in the sense of always expecting the worst broken hardware variants
to be out there I must say I'd rather have seen that GCC were beter. But
yes, sure.
Rene.
next prev parent reply other threads:[~2008-08-18 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 20:38 [PATCH] wss_lib: snd_wss_calibrate_mute improvement Krzysztof Helt
2008-08-18 8:50 ` Rene Herman [this message]
2008-08-18 10:16 ` Takashi Iwai
2008-08-18 11:04 ` Rene Herman
-- strict thread matches above, loose matches on Subject: below --
2008-08-18 11:16 krzysztof.h1
2008-08-18 12:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A937C7.2040600@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.